Handle case when lone wildcard is ORed with other constraints #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
=========================================
Coverage 97.32% 97.33%
- Complexity 209 210 +1
=========================================
Files 32 32
Lines 861 863 +2
=========================================
+ Hits 838 840 +2
Misses 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
localheinz
force-pushed
the
feature/lone-wildcard-always-wins
branch
from
185a788 to
8592895
Compare
localheinz
approved these changes
Apr 10, 2025
|
Thank you, @fredden! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on another feature, I noticed that a constraint like
* || 1.2.3wasn't being normalised to just*as expected. This pull request fixes this oversight.While working on this change, I noticed that a constraint like
*, 1.2.3isn't normalised to1.2.3. Let's deal with this in a separate step. (It's late here and I'm tired.)